Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read_rows shouldn't extend the user's deadline #468

Open
igorbernstein2 opened this issue Nov 1, 2021 · 1 comment
Open

read_rows shouldn't extend the user's deadline #468

igorbernstein2 opened this issue Nov 1, 2021 · 1 comment
Assignees
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. type: cleanup An internal cleanup or hygiene concern.

Comments

@igorbernstein2
Copy link
Contributor

# The `timeout` parameter must be somewhat greater than the value
# contained in `self.retry`, in order to avoid race-like condition and
# allow registering the first deadline error before invoking the retry.
# Otherwise there is a risk of entering an infinite loop that resets
# the timeout counter just before it being triggered. The increment
# by 1 second here is customary but should not be much less than that.
self.response_iterator = read_method(request, timeout=self.retry._deadline + 1)

Artificially adds 1 sec to a read rows deadline. This is a bit surprising. We should investigate a way to avoid doing this (while also avoiding the infinite loop the comment mentions)

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Nov 1, 2021
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Nov 3, 2021
@meredithslota meredithslota added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Nov 15, 2021
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Feb 13, 2022
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 30, 2022
@meredithslota
Copy link

This was added here: #16 and has moved upwards in the file to

# The `timeout` parameter must be somewhat greater than the value
but has the same rationale. I'm classifying this as a type: cleanup instead of a bug unless you feel strongly this is a bug instead of a potentially-now-obsolete feature. 😄

@meredithslota meredithslota added type: cleanup An internal cleanup or hygiene concern. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. labels May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

4 participants