fix: directly append to pb for better read row performance #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigtable
google-cla
bot
added
the
cla: yes
kolea2
reviewed
Jul 20, 2021
| @@ -137,7 +137,7 @@ def _update_message_request(self, message): | |||
| :param message: The ``ReadRowsRequest`` protobuf | |||
| """ | |||
| for each in self.row_keys: | |||
| message.rows.row_keys.append(_to_bytes(each)) | |||
| message.rows.row_keys._pb.append(_to_bytes(each)) | |||
There was a problem hiding this comment.
is it at all possible we could run into the same issues we same here with lazy eval? #359
There was a problem hiding this comment.
I wouldn't expect so. We have applied a similar patch to firestore and pubsub libraries. row_keys.append calls proto plus which ultimately will interact with _pb. The way it does this though is not fast. :(
kolea2
approved these changes
Jul 20, 2021
tseaver
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interacting directly with _pb rather than proto-plus gives a significant performance advantage.