feat: backup restore to different instance #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: backup restore to another Instance * fix: typo
…ackup-different-instance # Conflicts: # google/cloud/bigtable/backup.py # tests/system.py # tests/unit/test_backup.py
…ackup-different-instance
product-auto-label
bot
added
the
api: bigtable
google-cla
bot
added
the
cla: yes
|
@liubonan fyi |
kolea2
added
the
do not merge
tseaver
approved these changes
Apr 27, 2021
kolea2
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
kolea2
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
kolea2
removed
the
do not merge
crwilcox
approved these changes
Apr 30, 2021
tests/system.py
Outdated
| ).result() | ||
| tables = Config.INSTANCE_DATA.list_tables() | ||
| self.assertIn(restored_table, tables) | ||
| restored_table.delete() | ||
|
|
||
| # Testing `Backup.restore()` into a different instance: | ||
| # Setting up another instance... | ||
| alt_instance_id = "gcp-" + UNIQUE_SUFFIX |
There was a problem hiding this comment.
it: I found it odd the instance Id doesn't state it is an alt. the default instance id is INSTANCE_ID = "g-c-p" + UNIQUE_SUFFIX. I thought this would be something like g-c-p-alt + unique suffix or INSTANCE_ID + "-alt"
kolea2
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.