Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 'Rowset.add_row_range_with_prefix' #30

Merged
merged 14 commits into from Aug 4, 2020

Conversation

HemangChothani
Copy link
Contributor

Fixes #24

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 8, 2020
@HemangChothani
Copy link
Contributor Author

System test failed is not relevant to changes, it throws error like Operation successfully rolled back : Insufficient node quota

@HemangChothani HemangChothani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 19, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 19, 2020
google/cloud/bigtable/row_set.py Outdated Show resolved Hide resolved
docs/snippets_table.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @crwilcox any additional concerns?

@tseaver tseaver changed the title feat(bigtable): add support read row by prefix feat: add 'Rowset.add_row_range_with_prefix' Aug 3, 2020
@tseaver
Copy link
Contributor

tseaver commented Aug 3, 2020

System test failures due to leaked nodes (exceeding quota) and a (maybe related) 401 in the subsequent test's teardown.

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2020
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2020
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2020
@tseaver tseaver dismissed crwilcox’s stale review August 4, 2020 17:14

Requested change applied in 909ba28

@tseaver tseaver merged commit 4796ac8 into googleapis:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reading by prefix
6 participants