Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests.unit.test_policy.TestPolicy: test_from_pb_empty failed #262

Closed
flaky-bot bot opened this issue Mar 23, 2021 · 4 comments
Closed

tests.unit.test_policy.TestPolicy: test_from_pb_empty failed #262

flaky-bot bot opened this issue Mar 23, 2021 · 4 comments
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Mar 23, 2021

This test failed!

To configure my behavior, see the Flaky Bot documentation.

If I'm commenting on this issue too often, add the flakybot: quiet label and
I will stop commenting.


commit: 542737d
buildURL: Build Status, Sponge
status: failed

Test output
self = 
def test_from_pb_empty(self):
    from google.iam.v1 import policy_pb2

    empty = frozenset()
    message = policy_pb2.Policy()
    klass = self._get_target_class()
    policy = klass.from_pb(message)
    self.assertEqual(policy.etag, b"")
    self.assertEqual(policy.version, 0)
    self.assertEqual(policy.bigtable_admins, empty)
    self.assertEqual(policy.bigtable_readers, empty)
    self.assertEqual(policy.bigtable_users, empty)
    self.assertEqual(policy.bigtable_viewers, empty)
  self.assertEqual(len(policy), 0)

E AssertionError: 4 != 0

tests/unit/test_policy.py:103: AssertionError

@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 23, 2021
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Mar 23, 2021
@flaky-bot
Copy link
Author

flaky-bot bot commented Mar 24, 2021

commit: 0072732
buildURL: Build Status, Sponge
status: failed

Test output
self = 
def test_from_pb_empty(self):
    from google.iam.v1 import policy_pb2

    empty = frozenset()
    message = policy_pb2.Policy()
    klass = self._get_target_class()
    policy = klass.from_pb(message)
    self.assertEqual(policy.etag, b"")
    self.assertEqual(policy.version, 0)
    self.assertEqual(policy.bigtable_admins, empty)
    self.assertEqual(policy.bigtable_readers, empty)
    self.assertEqual(policy.bigtable_users, empty)
    self.assertEqual(policy.bigtable_viewers, empty)
  self.assertEqual(len(policy), 0)

E AssertionError: 4 != 0

tests/unit/test_policy.py:103: AssertionError

@flaky-bot
Copy link
Author

flaky-bot bot commented Mar 24, 2021

commit: 7d5c7aa
buildURL: Build Status, Sponge
status: failed

Test output
self = 
def test_from_pb_empty(self):
    from google.iam.v1 import policy_pb2

    empty = frozenset()
    message = policy_pb2.Policy()
    klass = self._get_target_class()
    policy = klass.from_pb(message)
    self.assertEqual(policy.etag, b"")
    self.assertEqual(policy.version, 0)
    self.assertEqual(policy.bigtable_admins, empty)
    self.assertEqual(policy.bigtable_readers, empty)
    self.assertEqual(policy.bigtable_users, empty)
    self.assertEqual(policy.bigtable_viewers, empty)
  self.assertEqual(len(policy), 0)

E AssertionError: 4 != 0

tests/unit/test_policy.py:103: AssertionError

@crwilcox crwilcox added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Mar 29, 2021
@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label Mar 30, 2021
@flaky-bot
Copy link
Author

flaky-bot bot commented Mar 30, 2021

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.


When run at the same commit (7d5c7aa), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

@kolea2
Copy link
Collaborator

kolea2 commented Jun 2, 2021

This was a bug in api core which was fixed in googleapis/python-api-core#159

@kolea2 kolea2 closed this as completed Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants