Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support filtering on incrementable values #178

Merged
merged 3 commits into from Jan 27, 2021
Merged

feat: support filtering on incrementable values #178

merged 3 commits into from Jan 27, 2021

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Dec 2, 2020

Closes #177.

@tseaver
docs: document that 'regex' may be either bytes or text
fb8cbb5 
Add an explicit test for that.
@tseaver
feat: add 'ExactValueFilter' shortcut.
57409c9 
Wraps around 'ValueRegexFilter', but also converts an integer value
to the equivalent packed 8-octet bytes.

See #177.
@tseaver
feat: allow integer values for 'ValueRangeFilter'
1710bf7 
Convert them to the equivalent packed 8-octet bytes values.

Closes #177.
@tseaver tseaver requested a review from a team as a code owner December 2, 2020 16:06
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Dec 2, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 2, 2020
@tseaver
Copy link
Contributor Author

tseaver commented Jan 12, 2021

@billyjacobson PTAL.

billyjacobson
billyjacobson approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@billyjacobson billyjacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a Bigtable perspective.

@tseaver tseaver merged commit e221352 into master Jan 27, 2021
@tseaver tseaver deleted the 177-filter-on-incrementable-values branch January 27, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyjacobson billyjacobson billyjacobson approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for filtering based on incrementable values
2 participants
@tseaver @billyjacobson