Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add response status to DirectRow.commit() #128

Merged
merged 2 commits into from Sep 22, 2020
Merged

feat: add response status to DirectRow.commit() #128

merged 2 commits into from Sep 22, 2020

Conversation

ryanyuan
Copy link
Contributor

@ryanyuan ryanyuan commented Sep 18, 2020 •
edited

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #127 馃

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 18, 2020
@ryanyuan ryanyuan force-pushed the feature/add-status-to-row-commit branch from c671fd3 to 666a908 Compare September 18, 2020 12:17
@ryanyuan ryanyuan changed the title Add response status to DirectRow.commit() feat: add response status to DirectRow.commit() Sep 18, 2020
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Sep 19, 2020
tseaver
tseaver suggested changes Sep 21, 2020
View reviewed changes
tests/unit/test_row.py Outdated Show resolved Hide resolved
tests/unit/test_row.py Outdated Show resolved Hide resolved
tests/unit/test_row.py Outdated Show resolved Hide resolved
tests/unit/test_row.py Outdated Show resolved Hide resolved
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 21, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 21, 2020
@ryanyuan ryanyuan requested a review from a team as a code owner September 22, 2020 07:16
@ryanyuan ryanyuan requested review from tseaver and removed request for a team September 22, 2020 07:22
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 22, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 22, 2020
@tseaver tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Sep 22, 2020
@tseaver
Copy link
Contributor

tseaver commented Sep 22, 2020

Unrelated systest failure reported in #140.

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 22, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 22, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 2478bb8 into googleapis:master Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DirectRow.commit() should return response state
3 participants
@ryanyuan @tseaver @yoshi-kokoro