Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DirectRow.commit() should return response state #127

Closed
ryanyuan opened this issue Sep 18, 2020 · 0 comments · Fixed by #128
Closed

DirectRow.commit() should return response state #127

ryanyuan opened this issue Sep 18, 2020 · 0 comments · Fixed by #128
Assignees
@yoshi-automation
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@ryanyuan
Copy link
Contributor

When I run direct_row.commit(), I thought it succeeded but it didn't. It didn't give me any responses saying the error code or something. It turned out that I was using a wrong column family ID.

The behaviour of DirectRow.commit() should return a response status, same as Table.mutate_rows() because DirectRow.commit() actually calls Table.mutate_rows().
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Sep 18, 2020
@ryanyuan ryanyuan mentioned this issue Sep 18, 2020
Merged
4 tasks
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Sep 19, 2020
@tseaver tseaver added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Sep 21, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Sep 22, 2020
@ryanyuan
feat: add response status to DirectRow.commit() (#128)
2478bb8 
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigtable/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)

Fixes #127  🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoshi-automation yoshi-automation

Labels
api: bigtable Issues related to the googleapis/python-bigtable API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add response status to DirectRow.commit() ryanyuan/python-bigtable
3 participants
@tseaver @ryanyuan @yoshi-automation