fix: retry if failure occurs on initial call in MutateRows #123
Conversation
crwilcox
added
the
do not merge
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigtable
crwilcox
removed
the
do not merge
| mutate_rows_request, retry=None | ||
| ) | ||
| try: | ||
| responses = data_client._inner_api_calls["mutate_rows"]( |
There was a problem hiding this comment.
Is this already handled in read rows or does it need to be added there as well?
There was a problem hiding this comment.
all methods that changed: googleapis/googleapis@a175708
There was a problem hiding this comment.
Solid call out. this may need to be done broadly to manage the initial setup calls.
There was a problem hiding this comment.
both "read_rows" and "sample_rows" return the raw api call right now. So I think this is complete for now, as we do no special handling beyond gapic configs for these.
| responses = data_client._inner_api_calls["mutate_rows"]( | ||
| mutate_rows_request, retry=None | ||
| ) | ||
| except (ServiceUnavailable, DeadlineExceeded, Aborted): |
There was a problem hiding this comment.
Can this PR change the _is_retryable method on this class to us the imported exceptions, too (to DRY that bit out).
tseaver
changed the title
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
google-cla
bot
added
cla: no
|
@googlebot I consent. |
google-cla
bot
added
cla: yes
An issue identified that in certain cases we weren't retrying
ServiceUnavailable. According the stack trace, it seems to come from the initial call.I am currently running a stress test against this change to see if the exception path is activated.
Fixes #115