Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add Samples section to CONTRIBUTING.rst #785

Merged
merged 1 commit into from Jul 21, 2021
Merged

docs: add Samples section to CONTRIBUTING.rst #785

merged 1 commit into from Jul 21, 2021

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Jul 20, 2021

Source-Link: googleapis/synthtool@52e4e46
Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:6186535cbdbf6b9fe61f00294929221d060634dae4a0795c1cefdbc995b2d605

@gcf-owl-bot
feat: add Samples section to CONTRIBUTING.rst
bae7547 
Source-Link: googleapis/synthtool@52e4e46
Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:6186535cbdbf6b9fe61f00294929221d060634dae4a0795c1cefdbc995b2d605
@gcf-owl-bot gcf-owl-bot bot requested a review from a team July 20, 2021 09:13
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners July 20, 2021 09:13
@gcf-owl-bot gcf-owl-bot bot requested review from loferris and removed request for a team July 20, 2021 09:13
@gcf-owl-bot gcf-owl-bot bot requested a review from dandhlee July 20, 2021 09:13
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Jul 20, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 20, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 20, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 20, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 20, 2021
@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 20, 2021
plamut
plamut approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Edit: @parthea Why no merge? So we need to wait for anything else?

@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 21, 2021
@plamut plamut merged commit e587029 into master Jul 21, 2021
@plamut plamut deleted the owl-bot-update-lock-6186535cbdbf6b9fe61f00294929221d060634dae4a0795c1cefdbc995b2d605 branch July 21, 2021 17:37
@tswast tswast mentioned this pull request Jul 21, 2021
Closed
@tseaver tseaver mentioned this pull request Jul 21, 2021
Closed
@tswast tswast changed the title feat: add Samples section to CONTRIBUTING.rst docs: add Samples section to CONTRIBUTING.rst Jul 21, 2021
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@plamut plamut plamut approved these changes

@loferris loferris Awaiting requested review from loferris

@dandhlee dandhlee Awaiting requested review from dandhlee

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement. owl-bot-update-lock
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tswast @plamut @parthea @yoshi-kokoro