Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add LoadJobConfig.projection_fields to select DATASTORE_BACKUP fields #736

Merged
merged 5 commits into from Jul 15, 2021
Merged

feat: add LoadJobConfig.projection_fields to select DATASTORE_BACKUP fields #736

merged 5 commits into from Jul 15, 2021

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Jul 2, 2021 •
edited

For https://issuetracker.google.com/191814927

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@tswast tswast requested a review from a team July 2, 2021 18:03
@tswast tswast requested a review from a team as a code owner July 2, 2021 18:03
@tswast tswast requested review from loferris and removed request for a team July 2, 2021 18:03
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 2, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Jul 2, 2021
@tswast tswast mentioned this pull request Jul 2, 2021
Merged
plamut
plamut reviewed Jul 5, 2021
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just have two remarks/questions.

google/cloud/bigquery/job/load.py Show resolved Hide resolved
google/cloud/bigquery/job/load.py Outdated Show resolved Hide resolved
@tswast tswast requested a review from plamut July 9, 2021 19:10
plamut
plamut reviewed Jul 10, 2021
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should annotate the setter, too. And resolve a merge conflict now that a few other PRs have been merged.

Edit: Resolved it myself, it was trivial (merging the typing imports).

google/cloud/bigquery/job/load.py Show resolved Hide resolved
@tswast tswast requested a review from plamut July 14, 2021 20:24
@tswast tswast changed the title feat: add LoadJobConfig.projection_fields to select DATASTORE_BACKUP fields feat: add LoadJobConfig.projection_fields to select DATASTORE_BACKUP fields Jul 14, 2021
@plamut plamut merged commit c45a738 into googleapis:master Jul 15, 2021
@tswast tswast deleted the b191814927-projection_fields branch July 15, 2021 14:04
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 16, 2021
@tswast
docs: add loading data from Firestore backup sample (#737)
22fd848 
Follow-up to #736

To be included here: https://cloud.google.com/bigquery/docs/loading-data-cloud-firestore

Also

* Use `google-cloud-testutils` for cleanup as described in googleapis/python-test-utils#39
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 19, 2021
@release-please
chore: release 2.22.0 (#771)
5802092 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.22.0](https://www.github.com/googleapis/python-bigquery/compare/v2.21.0...v2.22.0) (2021-07-19)


### Features

* add `LoadJobConfig.projection_fields` to select DATASTORE_BACKUP fields ([#736](https://www.github.com/googleapis/python-bigquery/issues/736)) ([c45a738](https://www.github.com/googleapis/python-bigquery/commit/c45a7380871af3dfbd3c45524cb606c60e1a01d1))
* add standard sql table type, update scalar type enums ([#777](https://www.github.com/googleapis/python-bigquery/issues/777)) ([b8b5433](https://www.github.com/googleapis/python-bigquery/commit/b8b5433898ec881f8da1303614780a660d94733a))
* add support for more detailed DML stats ([#758](https://www.github.com/googleapis/python-bigquery/issues/758)) ([36fe86f](https://www.github.com/googleapis/python-bigquery/commit/36fe86f41c1a8f46167284f752a6d6bbf886a04b))
* add support for user defined Table View Functions ([#724](https://www.github.com/googleapis/python-bigquery/issues/724)) ([8c7b839](https://www.github.com/googleapis/python-bigquery/commit/8c7b839a6ac1491c1c3b6b0e8755f4b70ed72ee3))


### Bug Fixes

* avoid possible job already exists error ([#751](https://www.github.com/googleapis/python-bigquery/issues/751)) ([45b9308](https://www.github.com/googleapis/python-bigquery/commit/45b93089f5398740413104285cc8acfd5ebc9c08))


### Dependencies

* allow 2.x versions of `google-api-core`, `google-cloud-core`, `google-resumable-media` ([#770](https://www.github.com/googleapis/python-bigquery/issues/770)) ([87a09fa](https://www.github.com/googleapis/python-bigquery/commit/87a09fa3f2a9ab35728a1ac925f9d5f2e6616c65))


### Documentation

* add loading data from Firestore backup sample ([#737](https://www.github.com/googleapis/python-bigquery/issues/737)) ([22fd848](https://www.github.com/googleapis/python-bigquery/commit/22fd848cae4af1148040e1faa31dd15a4d674687))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut approved these changes

@loferris loferris Awaiting requested review from loferris

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tswast @plamut