Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add determinism level for javascript UDFs #522

Merged
merged 2 commits into from Feb 17, 2021
Merged

feat: add determinism level for javascript UDFs #522

merged 2 commits into from Feb 17, 2021

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Feb 15, 2021

Closes #503.

This PR adds support for the determinism level setting for user-defined routines.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut requested review from a team and steffnay and removed request for a team February 15, 2021 12:52
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Feb 15, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 15, 2021
plamut
plamut commented Feb 16, 2021
View reviewed changes
tests/system/test_client.py Outdated Show resolved Hide resolved
@plamut plamut requested a review from tswast February 17, 2021 12:19
tswast
tswast approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tswast tswast merged commit edd3328 into googleapis:master Feb 17, 2021
@plamut plamut deleted the iss-503 branch February 17, 2021 16:57
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@steffnay steffnay Awaiting requested review from steffnay

@shollyman shollyman Awaiting requested review from shollyman

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQuery feature: support determinism level for javascript UDFs
2 participants
@plamut @tswast