feat: pass retry from Job.result() to Job.done()

[IlyaFaer]

Closes #24

[IlyaFaer]

This PR is strictly connected to googleapis/python-api-core#9, and should not be merged before №9

[IlyaFaer]

Here is how it's gonna be passed into done()

[tswast]

This will need to be updated to set the minimum api-core version in setup.py to 1.23.0 after googleapis/python-api-core#96 is released.

[tswast]

1.23.0 has been released. Work can continue on this PR

[IlyaFaer]

Only one error is appearing:

self = <google.cloud.bigquery.job._AsyncJob object at 0x7f1fc2f0eb70>

    def to_api_repr(self):
        """Generate a resource for the job."""
>       raise NotImplementedError("Abstract")
E       NotImplementedError: Abstract

Doesn't seem to be related.

[tswast]

Missing update to minimum versions.

[tswast]

Filed #339 to look into the test failure. I've assigned to myself, as it might be related to some refactoring I recently completed.

[IlyaFaer]

I think, a lot of tests will fail. And in many tests we'll have to add one more arg. That's why I've added the kwargs pattern.

[tswast]

I think, a lot of tests will fail. And in many tests we'll have to add one more arg. That's why I've added the kwargs pattern.

Okay, that makes sense. So long as we have some tests that have a custom retry, I'm okay with only populating it when it's something other than the default.

[tswast]

I'm not seeing any tests that verify the retry behavior is working as expected.

I'd like to see the test update I suggested here: https://github.com/googleapis/python-bigquery/pull/340/files#r511017196

The QueryJob class overrides result(), so we'll need a test that does the same but for QueryJob specifically.

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[HemangChothani]

@googlebot I consent

[IlyaFaer]

@tswast, sorry, I'm little bit besieged by tasks, not able to continue with this right now. @HemangChothani kindly agreed to take a look at this PR.