Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add TableReference.__str__ to get table ID in standard SQL #405

Merged
merged 3 commits into from Nov 30, 2020
Merged

feat: add TableReference.__str__ to get table ID in standard SQL #405

merged 3 commits into from Nov 30, 2020

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Nov 30, 2020 •
edited

This is the natural inverse of the TableReference.from_string method.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #354 🦕

@tswast
feat: add TableReference.__str__ to get table ID in standard SQL fo…
2ff0aa5 
…rmat

This is the natural inverse of the `TableReference.from_string` method.
@tswast tswast requested review from steffnay and a team November 30, 2020 19:59
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 30, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 30, 2020
@tswast tswast mentioned this pull request Nov 30, 2020
Closed
@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Nov 30, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 53dff2a into googleapis:master Nov 30, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 30, 2020
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffnay steffnay steffnay approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to get period separated table id from Table Object
2 participants
@tswast @steffnay