Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update intersphinx links #404

Merged
merged 4 commits into from Dec 7, 2020
Merged

docs: update intersphinx links #404

merged 4 commits into from Dec 7, 2020

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Nov 30, 2020

Also, updates synth.py to avoid manual hacks, such as to work around the breaking change in #316 until we figure out how to use proto-plus classes directly #319.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Closes #336
Closes #325
Closes #316

@tswast tswast requested a review from a team November 30, 2020 16:51
@tswast tswast requested a review from a team as a code owner November 30, 2020 16:51
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 30, 2020
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 30, 2020
@tswast
Copy link
Contributor Author

tswast commented Nov 30, 2020

Generated with python -m synthtool on the latest synthtool commit, checked out locally.

@tswast tswast requested a review from shollyman December 2, 2020 19:36
shollyman
shollyman approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, with the caveat that it's not clear what here is generated vs manual config change.

@tswast
Copy link
Contributor Author

tswast commented Dec 3, 2020

Thanks @shollyman

The only manual changes are to synth.py

@tswast tswast merged commit a9d8ae8 into googleapis:master Dec 7, 2020
@tswast tswast deleted the restore-py_samples branch December 7, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@stephaniewang526 stephaniewang526 Awaiting requested review from stephaniewang526

@steffnay steffnay Awaiting requested review from steffnay

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tswast @shollyman