Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support CSV format in load_table_from_dataframe pandas connector #399

Merged
merged 8 commits into from Dec 7, 2020
Merged

feat: support CSV format in load_table_from_dataframe pandas connector #399

merged 8 commits into from Dec 7, 2020

Conversation

cguardia
Copy link
Contributor

@cguardia cguardia commented Nov 24, 2020 •
edited

for load_table_from_dataframe

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #383 馃

@cguardia
WIP: support alternative serialization formats
d588cec 
for load_table_from_dataframe
@cguardia cguardia requested review from a team and steffnay November 24, 2020 09:40
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 24, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 24, 2020
@cguardia cguardia mentioned this pull request Nov 24, 2020
Closed
tswast
tswast reviewed Nov 24, 2020
View reviewed changes
google/cloud/bigquery/client.py Outdated Show resolved Hide resolved
google/cloud/bigquery/client.py Outdated Show resolved Hide resolved
google/cloud/bigquery/client.py Outdated Show resolved Hide resolved
tests/system.py Outdated Show resolved Hide resolved
tests/system.py Show resolved Hide resolved
@cguardia
Copy link
Contributor Author

cguardia commented Dec 2, 2020

@tswast sorry for the delay. I think this addresses your comments.

@tswast tswast changed the title WIP: support alternative serialization formats feat: support CSV format in load_table_from_dataframe pandas connector Dec 7, 2020
@tswast tswast merged commit 0046742 into googleapis:master Dec 7, 2020
@tswast tswast mentioned this pull request Dec 21, 2020
Closed
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@steffnay steffnay Awaiting requested review from steffnay

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

load_table_from_dataframe -- support alternative serialization formats
2 participants
@cguardia @tswast