Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update required version of opentelementry for opentelemetry-exporter-google-cloud #398

Merged
merged 2 commits into from Nov 24, 2020
Merged

deps: update required version of opentelementry for opentelemetry-exporter-google-cloud #398

merged 2 commits into from Nov 24, 2020

Conversation

HemangChothani
Copy link
Contributor

Fixes #359

@HemangChothani HemangChothani requested review from tswast and a team November 21, 2020 12:21
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 21, 2020
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 21, 2020
tswast
tswast approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bonus benefit of this change: compatible with the version used in Spanner.

https://github.com/googleapis/python-spanner/blob/864f09ce605164b3b76194df485c15cdc8828ed8/setup.py#L40-L42

@tswast tswast merged commit 673a9cb into googleapis:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

google-cloud-bigquery[opentelemetry] un-installable together with opentelemetry-exporter-google-cloud
2 participants
@HemangChothani @tswast