Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing spaces in opentelemetry log message #360

Merged
merged 2 commits into from Nov 3, 2020
Merged

fix: add missing spaces in opentelemetry log message #360

merged 2 commits into from Nov 3, 2020

Conversation

rickard-von-essen
Copy link
Contributor

Currently this log message renders like this:

This service is instrumented using OpenTelemetry.OpenTelemetry could not be imported; pleaseadd opentelemetry-api and opentelemetry-instrumentationpackages in order to get BigQuery Tracing data.

where it should be

This service is instrumented using OpenTelemetry. OpenTelemetry could not be imported; please add opentelemetry-api and opentelemetry-instrumentation packages in order to get BigQuery Tracing data."

@rickard-von-essen rickard-von-essen requested review from a team and shollyman November 3, 2020 13:00
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 3, 2020
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 3, 2020
@rickard-von-essen
fix: Add missing spaces in log message
8cfc086 
Currently this log message renders like this:

```
This service is instrumented using OpenTelemetry.OpenTelemetry could not be imported; pleaseadd
opentelemetry-api and opentelemetry-instrumentationpackages in order to get BigQuery Tracing data.
```

where it should be

```
This service is instrumented using OpenTelemetry. OpenTelemetry could not be imported; please add
opentelemetry-api and opentelemetry-instrumentation packages in order to get BigQuery Tracing data."
```
@tswast tswast added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 3, 2020
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 3, 2020
@tswast tswast changed the title Add missing spaces in log message fix: add missing spaces in opentelemetry log message Nov 3, 2020
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 3, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 3, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 4f326b1 into googleapis:master Nov 3, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 3, 2020
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@shollyman shollyman Awaiting requested review from shollyman

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rickard-von-essen @tswast @yoshi-kokoro