Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: split job.py and test_job.py #358

Closed
tswast opened this issue Nov 2, 2020 · 0 comments · Fixed by #361
Closed

refactor: split job.py and test_job.py #358

tswast opened this issue Nov 2, 2020 · 0 comments · Fixed by #361
Assignees
@tswast
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. type: process A process-related concern. May include testing, release, or the like.

Comments

@tswast
Copy link
Contributor

tswast commented Nov 2, 2020

job.py and test_job.py are both thousands of lines long. It's actually causing my code editor to slow down. These files have a natural split into the various job types:

  • _base -- for the _AsyncJob base class
  • extract
  • copy
  • load
  • query

The job/__init__.py should import all of these sub-modules to retain backwards compatibility.

Might want to wait for #41 and #347 to be merged before working on this.
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 2, 2020
@tswast tswast self-assigned this Nov 2, 2020
@tswast tswast added the type: process A process-related concern. May include testing, release, or the like. label Nov 2, 2020
@tswast tswast mentioned this issue Nov 3, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tswast tswast

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: break job into multiple modules tswast/python-bigquery
1 participant
@tswast