Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_AsyncJob test failure #339

Closed
tswast opened this issue Oct 23, 2020 · 1 comment · Fixed by #340
Closed

_AsyncJob test failure #339

tswast opened this issue Oct 23, 2020 · 1 comment · Fixed by #340
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@tswast
Copy link
Contributor

tswast commented Oct 23, 2020

https://source.cloud.google.com/results/invocations/13cec9de-6f0f-4392-a32b-075930bd6c99/targets/cloud-devrel%2Fclient-libraries%2Fpython%2Fgoogleapis%2Fpython-bigquery%2Fpresubmit%2Fpresubmit/log

___________________ Test_AsyncJob.test_result_retry_to_done ____________________

self = <tests.unit.test_job.Test_AsyncJob testMethod=test_result_retry_to_done>

    def test_result_retry_to_done(self):
        client = _make_client(project=self.PROJECT)
        job = self._make_one(self.JOB_ID, client)
        done = job.done = mock.Mock()
        retry = mock.Mock()

>       job.result(retry=retry)

tests/unit/test_job.py:999:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
google/cloud/bigquery/job.py:819: in result
    self._begin(retry=retry, timeout=timeout)
google/cloud/bigquery/job.py:631: in _begin
    data=self.to_api_repr(),
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <google.cloud.bigquery.job._AsyncJob object at 0x7fc21b43bcd0>

    def to_api_repr(self):
        """Generate a resource for the job."""
>       raise NotImplementedError("Abstract")
E       NotImplementedError: Abstract

google/cloud/bigquery/job.py:591: NotImplementedError
@tswast tswast self-assigned this Oct 23, 2020
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Oct 23, 2020
@tswast tswast added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed api: bigquery Issues related to the googleapis/python-bigquery API. labels Oct 23, 2020
@tswast tswast added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Oct 23, 2020
@tswast
Copy link
Contributor Author

tswast commented Oct 23, 2020

Dropping to p2, since this is actually a new test in #41, but I'll keep working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant