Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove uses of get_distribution to better support package vendoring #304

Closed
tswast opened this issue Oct 6, 2020 · 0 comments · Fixed by #307
Closed

Remove uses of get_distribution to better support package vendoring #304

tswast opened this issue Oct 6, 2020 · 0 comments · Fixed by #307
Assignees
@HemangChothani
Labels
type: process A process-related concern. May include testing, release, or the like.

Comments

@tswast
Copy link
Contributor

tswast commented Oct 6, 2020

get_distribution doesn't function when packages are vendored. We should remove uses of this function.

python-bigquery/google/cloud/bigquery/__init__.py

Line 33 in d1eb8b3

__version__ = get_distribution("google-cloud-bigquery").version

See: googleapis/python-api-core#80 as an example of how to fix this using a "version" module. Release tooling is being updated to support this method.
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Oct 6, 2020
@tswast tswast added type: process A process-related concern. May include testing, release, or the like. and removed api: bigquery Issues related to the googleapis/python-bigquery API. labels Oct 6, 2020
@HemangChothani HemangChothani self-assigned this Oct 7, 2020
@HemangChothani HemangChothani mentioned this issue Oct 7, 2020
Merged
@plamut plamut mentioned this issue May 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HemangChothani HemangChothani

Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use version.py instead of pkg_resources.get_distribution MaxxleLLC/python-bigquery
2 participants
@tswast @HemangChothani