Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support string_dtype, etc. in to_geodataframe #1902

Open
bnaul opened this issue Apr 15, 2024 · 2 comments
Open

Support string_dtype, etc. in to_geodataframe #1902

bnaul opened this issue Apr 15, 2024 · 2 comments
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@bnaul
Copy link
Contributor

bnaul commented Apr 15, 2024

Way back in #954 @tswast and I were discussing support for pyarrow-backed strings, that was added by @chelsea-lin in #1529 by way of the string_dtype etc arguments.

Would it make sense to add the same thing to the to_geodataframe API? Especially now that pandas is moving towards using the arrow backend by default, I think it would be nice to support these types everywhere.
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Apr 15, 2024
@tswast
Copy link
Contributor

tswast commented Apr 15, 2024

I think that'd make a lot of sense.

@tswast tswast added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Apr 15, 2024
@Linchin Linchin added the priority: p3 Desirable enhancement or fix. May not be included in next release. label Apr 15, 2024
@chalmerlowe
Copy link
Contributor

I will take a look at this and see what we can come up with, unless you are already looking at a PR @bnaul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tswast @bnaul @chalmerlowe @Linchin @nayaknishant