Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for getting and setting table IAM policy #144

Merged
merged 16 commits into from Jul 30, 2020
Merged

feat: add support for getting and setting table IAM policy #144

merged 16 commits into from Jul 30, 2020

Conversation

steffnay
Copy link
Contributor

@steffnay steffnay commented Jun 23, 2020 •
edited

Adds support for interacting with IAM policies for BigQuery table resources.

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

🦕

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 23, 2020
@steffnay steffnay requested a review from shollyman June 23, 2020 03:41
@steffnay steffnay changed the title Table acl feat: adds support for getting and setting table IAM policy Jul 13, 2020
@steffnay steffnay added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 14, 2020
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 14, 2020
@steffnay steffnay marked this pull request as ready for review July 14, 2020 16:11
shollyman
shollyman reviewed Jul 14, 2020
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that's missing here is the testIamPermissions implementation and accompanying. Is that going to be in a followup PR?

google/cloud/bigquery/iam.py Outdated Show resolved Hide resolved
@shollyman
Copy link
Contributor

Testing is picking up unit test problems with pyarrow tests. Looks like they just jumped from 0.17.1 to 1.0, so possibly some more shenanigans afoot with changes there.

@shollyman
Copy link
Contributor

Given it's friday afternoon now, punting a release window on this until next week.

@shollyman
Copy link
Contributor

And ignore the previous two comments, I've been typing in the wrong PR

@steffnay steffnay added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 28, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 28, 2020
@steffnay steffnay requested a review from shollyman July 28, 2020 23:19
@tseaver tseaver changed the title feat: adds support for getting and setting table IAM policy feat: add support for getting and setting table IAM policy Jul 29, 2020
tseaver
tseaver suggested changes Jul 29, 2020
View reviewed changes
google/cloud/bigquery/client.py Outdated Show resolved Hide resolved
google/cloud/bigquery/client.py Outdated Show resolved Hide resolved
google/cloud/bigquery/client.py Outdated Show resolved Hide resolved
google/cloud/bigquery/client.py Outdated Show resolved Hide resolved
google/cloud/bigquery/client.py Outdated Show resolved Hide resolved
google/cloud/bigquery/client.py Outdated Show resolved Hide resolved
tests/system.py Outdated Show resolved Hide resolved
tests/unit/test_client.py Show resolved Hide resolved
tests/unit/test_client.py Outdated Show resolved Hide resolved
@steffnay steffnay added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 30, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 30, 2020
@tseaver tseaver merged commit f59fc9a into googleapis:master Jul 30, 2020
@brandonjchoi
Copy link

When will this be released @tseaver @shollyman ?

@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@shollyman shollyman Awaiting requested review from shollyman

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@steffnay @shollyman @brandonjchoi @tseaver @googlebot @yoshi-kokoro