Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: promote RowIterator.to_arrow_iterable to public method #1073

Merged
merged 3 commits into from Nov 19, 2021
Merged

feat: promote RowIterator.to_arrow_iterable to public method #1073

merged 3 commits into from Nov 19, 2021

Conversation

judahrand
Copy link
Contributor

@judahrand judahrand commented Nov 19, 2021 •
edited

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1072 🦕

@judahrand judahrand requested a review from a team November 19, 2021 11:29
@judahrand judahrand requested a review from a team as a code owner November 19, 2021 11:29
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 19, 2021
@judahrand judahrand force-pushed the to_arrow_iterable branch 2 times, most recently from 9c42717 to dd57bb1 Compare November 19, 2021 11:31
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2021
@tswast tswast changed the title Promote to_arrow_iterable to public method feat: promote RowIterator.to_arrow_iterable to public method Nov 19, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2021
tswast
tswast approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

google/cloud/bigquery/table.py Outdated Show resolved Hide resolved
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2021
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2021
@tswast tswast merged commit 21cd710 into googleapis:main Nov 19, 2021
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@judahrand @tswast @abdelmegahedgoogle
feat: promote RowIterator.to_arrow_iterable to public method (googl…
e7d54a4 
…eapis#1073)

* feat: promote `to_arrow_iterable` to public method

* use correct version number

* Update google/cloud/bigquery/table.py

Co-authored-by: Tim Swast <swast@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Promote _to_arrow_iterable to public method
3 participants
@judahrand @tswast @yoshi-kokoro