fix: error if eval()-ing repr(SchemaField) #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigquery
tseaver
reviewed
Nov 4, 2021
| evaled_field = eval(field_repr) | ||
|
|
||
| assert field == evaled_field | ||
|
|
There was a problem hiding this comment.
For completeness, do we need a round-trip test for the case where there is a policy tuple?
There was a problem hiding this comment.
Would not hurt, I'll add it.
There was a problem hiding this comment.
Guess what, that extra test actually revealed deeper issues in the repr() of SchemaField and PolicyTagList.
tseaver
approved these changes
Nov 4, 2021
The repr() should be evaluable.
plamut
added
the
do not merge
plamut
removed
the
do not merge
abdelmegahedgoogle
pushed a commit
to abdelmegahedgoogle/python-bigquery
that referenced
this pull request
Apr 17, 2023
* fix: error if eval()-ing repr(SchemaField) * Make repr(PolicyTagList) evaluable * Fix SchemaField repr with policy tags The repr() should be evaluable. Co-authored-by: Tres Seaver <tseaver@palladion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1041.
If policy tags are not set, the corresponding key should be
Noneto denote a missing value. An empty tuple should only be used when the schema has explicitly emptyPolicyTagListassigned.PR checklist: