New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a py.typed file for submodule #1019
Comments
Please don't until #987 is fixed. |
Do note, you may need to run mypy, pyright, pytype against our samples before merging. It will ensure that we aren't exposing users to failing type checks. Ideally we would add this to CI as well, to avoid future breakage. |
Update - we will adjust the annotations to make Even if type checks break for some people, it will only happen in the next major release, which should not happen automatically, if the BigQuery dependency is pinned to (note to self - besides adding the |
https://github.com/googleapis/python-bigquery/blob/main/setup.cfg has a pytype section. Is that tied in to packaging? I am unsure. |
Mypy is happy now, unblocking. We will only add |
Closed in #1058 (merged into the |
To be in accordance with PEP 561 we should add a py.typed file to google/cloud/bigquery/py.typed
The file can be empty but does need to be present for some type checkers.
The text was updated successfully, but these errors were encountered: