Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow queryJob.result() to be called on a dryRun #1015

Merged
merged 3 commits into from Oct 13, 2021
Merged

feat: allow queryJob.result() to be called on a dryRun #1015

merged 3 commits into from Oct 13, 2021

Conversation

steffnay
Copy link
Contributor

@steffnay steffnay commented Oct 11, 2021 •
edited

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1012 🦕

@steffnay steffnay requested a review from a team October 11, 2021 21:45
@steffnay steffnay requested a review from a team as a code owner October 11, 2021 21:45
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 11, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Oct 11, 2021
tswast
tswast requested changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can simplify the tests a bit.

tests/unit/job/test_query.py Outdated Show resolved Hide resolved
tests/unit/job/test_query.py Outdated Show resolved Hide resolved
tests/unit/job/test_query.py

calls = conn.api_request.mock_calls
self.assertEqual(result, None)
self.assertEqual(calls, [])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for checking that there were no API requests.

@steffnay steffnay requested a review from tswast October 12, 2021 21:38
@tswast tswast merged commit 685f06a into googleapis:main Oct 13, 2021
@tswast
Copy link
Contributor

tswast commented Oct 13, 2021

Thanks @steffnay !

@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@steffnay @abdelmegahedgoogle
feat: allow queryJob.result() to be called on a dryRun (googleapis#1015)
0742cf2 
* feat: allow queryJob.result() to be called on a dryRun

* update to return EmptyRowIterator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@loferris loferris Awaiting requested review from loferris

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: allow QueryJob.result() to be called on a dryRun query
2 participants
@steffnay @tswast