fix: executemany rowcount only reflected the last execution (#660)

googleapis · May 12, 2021 · aeadc8c · aeadc8c
1 parent 615d139
commit aeadc8c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/google/cloud/bigquery/dbapi/cursor.py b/google/cloud/bigquery/dbapi/cursor.py
@@ -218,6 +218,7 @@ def executemany(self, operation, seq_of_parameters):
                 Sequence of many sets of parameter values.
         """
         if seq_of_parameters:
+            rowcount = 0
             # There's no reason to format the line more than once, as
             # the operation only barely depends on the parameters.  So
             # we just use the first set of parameters. If there are
@@ -230,6 +231,9 @@ def executemany(self, operation, seq_of_parameters):
                 self._execute(
                     formatted_operation, parameters, None, None, parameter_types
                 )
+                rowcount += self.rowcount
+
+            self.rowcount = rowcount
 
     def _try_fetch(self, size=None):
         """Try to start fetching data, if not yet started.

diff --git a/tests/unit/test_dbapi_cursor.py b/tests/unit/test_dbapi_cursor.py
@@ -612,7 +612,7 @@ def test_executemany_w_dml(self):
             (("test",), ("anothertest",)),
         )
         self.assertIsNone(cursor.description)
-        self.assertEqual(cursor.rowcount, 12)
+        self.assertEqual(cursor.rowcount, 24)  # 24 because 2 * 12 because cumulatve.
 
     def test_executemany_empty(self):
         from google.cloud.bigquery.dbapi import connect