docs: add intersphinx to proto-plus library #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perviously, system tests allow users to pass in separate lists for `system_test_external_dependencies` and `unit_test_local_dependencies`, which would install dependencies needed for the test. Unit tests only had a single option called `unit_test_dependencies`, which only supported local packages. This PR makes unit tests consistent with system tests by handling `unit_test_external_dependencies` and `unit_test_local_dependencies`. I kept `unit_test_dependencies` around with it's previous behaviour for backwards compatibility, in case any repos are using it as-is. Source-Author: Daniel Sanche <d.sanche14@gmail.com> Source-Date: Mon Oct 26 13:46:03 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: fd3584b01cedd6c9f79d08be4e2365085f955aa5 Source-Link: googleapis/synthtool@fd3584b
Source-Author: Tim Swast <swast@google.com> Source-Date: Tue Oct 27 12:01:14 2020 -0500 Source-Repo: googleapis/synthtool Source-Sha: ea52b8a0bd560f72f376efcf45197fb7c8869120 Source-Link: googleapis/synthtool@ea52b8a
google-cla
bot
added
the
cla: yes
tswast
changed the title
tswast
approved these changes
Nov 4, 2020
tswast
added
the
automerge
|
Your PR has conflicts that you need to resolve before merge-on-green can automerge |
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Nov 10, 2020
Follow-up to #86 where I manually reverted a change to `noxfile.py`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was generated using Autosynth. 馃寛
Synth log will be available here:
https://source.cloud.google.com/results/invocations/56edb2e9-da3a-409f-a2ed-e969b45e2c63/targets
Source-Link: googleapis/synthtool@ea52b8a
Source-Link: googleapis/synthtool@fd3584b