Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't fail with 429 when downloading wide tables #79

Merged
merged 5 commits into from Oct 21, 2020
Merged

fix: don't fail with 429 when downloading wide tables #79

merged 5 commits into from Oct 21, 2020

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Oct 19, 2020 •
edited

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #78 馃

@tswast tswast requested a review from a team October 19, 2020 22:09
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 19, 2020
@tswast tswast mentioned this pull request Oct 19, 2020
Closed
@tswast tswast mentioned this pull request Oct 20, 2020
Closed
This was referenced Oct 20, 2020
Closed
Closed
cguardia
cguardia approved these changes Oct 21, 2020
View reviewed changes
Copy link

@cguardia cguardia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to go.

shollyman
shollyman approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only worry with something like this is that the synth change looks brittle, but if we've got a good signal for when synth changes aren't matching that's probably okay.

@tswast
Copy link
Contributor Author

tswast commented Oct 21, 2020

got a good signal for when synth changes aren't matching that's probably okay.

When running manually, we get a nice warning that it didn't match anything. Not sure what autosynth does in that case, though.

@tswast tswast merged commit 45faf97 into googleapis:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cguardia cguardia cguardia approved these changes

@shollyman shollyman shollyman approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reason: 429 Received message larger than max (6341826 vs. 4194304)
3 participants
@tswast @cguardia @shollyman