Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: request only a single stream in dataframe example #114

Merged
merged 2 commits into from Jan 13, 2021
Merged

docs: request only a single stream in dataframe example #114

merged 2 commits into from Jan 13, 2021

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Jan 12, 2021

This should prevent extra streams from being created and losing rows as a result.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #111 馃

@tswast tswast requested a review from a team as a code owner January 12, 2021 22:50
@tswast tswast requested review from kurtisvg and removed request for a team January 12, 2021 22:50
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. label Jan 12, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 12, 2021
@tswast tswast mentioned this pull request Jan 12, 2021
Closed
@tswast tswast merged commit 3518624 into googleapis:master Jan 13, 2021
@tswast tswast deleted the issue111-arrow-streams branch January 13, 2021 21:34
@tswast tswast mentioned this pull request Jan 22, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@kurtisvg kurtisvg Awaiting requested review from kurtisvg

@steffnay steffnay Awaiting requested review from steffnay

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apache Arrows streams only ~5 million records out of ~7 million records in the table
2 participants
@tswast @shollyman