From 66c09c01d643844117e3e35d2d90a6cc0491349e Mon Sep 17 00:00:00 2001 From: "gcf-owl-bot[bot]" <78513119+gcf-owl-bot[bot]@users.noreply.github.com> Date: Thu, 23 Sep 2021 10:04:10 +0000 Subject: [PATCH] fix: add missing read api retry setting on SplitReadStream (#311) - [ ] Regenerate this pull request now. Committer: @yirutang PiperOrigin-RevId: 398057257 Source-Link: https://github.com/googleapis/googleapis/commit/376e8e9285caeb8e53da3746a622c3d3a1dbc5ed Source-Link: https://github.com/googleapis/googleapis-gen/commit/32c05ed4ed88d83ad5cafc7544058acc58bf5628 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzJjMDVlZDRlZDg4ZDgzYWQ1Y2FmYzc1NDQwNThhY2M1OGJmNTYyOCJ9 --- .../services/big_query_read/async_client.py | 12 +++++++++++- .../services/big_query_read/transports/base.py | 14 +++++++++++++- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/google/cloud/bigquery_storage_v1/services/big_query_read/async_client.py b/google/cloud/bigquery_storage_v1/services/big_query_read/async_client.py index a7d74d46..522b3437 100644 --- a/google/cloud/bigquery_storage_v1/services/big_query_read/async_client.py +++ b/google/cloud/bigquery_storage_v1/services/big_query_read/async_client.py @@ -441,7 +441,17 @@ async def split_read_stream( # and friendly error handling. rpc = gapic_v1.method_async.wrap_method( self._client._transport.split_read_stream, - default_timeout=None, + default_retry=retries.Retry( + initial=0.1, + maximum=60.0, + multiplier=1.3, + predicate=retries.if_exception_type( + core_exceptions.DeadlineExceeded, + core_exceptions.ServiceUnavailable, + ), + deadline=600.0, + ), + default_timeout=600.0, client_info=DEFAULT_CLIENT_INFO, ) diff --git a/google/cloud/bigquery_storage_v1/services/big_query_read/transports/base.py b/google/cloud/bigquery_storage_v1/services/big_query_read/transports/base.py index 65da10ff..af7f5390 100644 --- a/google/cloud/bigquery_storage_v1/services/big_query_read/transports/base.py +++ b/google/cloud/bigquery_storage_v1/services/big_query_read/transports/base.py @@ -189,7 +189,19 @@ def _prep_wrapped_messages(self, client_info): client_info=client_info, ), self.split_read_stream: gapic_v1.method.wrap_method( - self.split_read_stream, default_timeout=None, client_info=client_info, + self.split_read_stream, + default_retry=retries.Retry( + initial=0.1, + maximum=60.0, + multiplier=1.3, + predicate=retries.if_exception_type( + core_exceptions.DeadlineExceeded, + core_exceptions.ServiceUnavailable, + ), + deadline=600.0, + ), + default_timeout=600.0, + client_info=client_info, ), }