Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove pytz from test dependencies #405

Open
tswast opened this issue Jan 19, 2022 · 2 comments
Open

remove pytz from test dependencies #405

tswast opened this issue Jan 19, 2022 · 2 comments
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@tswast
Copy link
Collaborator

tswast commented Jan 19, 2022

Using pytz in tests risks us accidentally including references to it in the actual library, which is no longer included as a transitive dependency for the core Google libraries.
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label Jan 19, 2022
@tswast tswast added type: process A process-related concern. May include testing, release, or the like. and removed api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. labels Jan 19, 2022
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label Jan 20, 2022
@chalmerlowe
Copy link
Collaborator

Based on current priorities and workload, downgrading this to a P3

@chalmerlowe chalmerlowe added the priority: p3 Desirable enhancement or fix. May not be included in next release. label Nov 11, 2022
@nayaknishant nayaknishant mentioned this issue Mar 1, 2023
Closed
@meredithslota meredithslota added priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern. priority: p3 Desirable enhancement or fix. May not be included in next release. and removed type: process A process-related concern. May include testing, release, or the like. priority: p3 Desirable enhancement or fix. May not be included in next release. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Mar 28, 2023
@nayaknishant nayaknishant mentioned this issue Sep 6, 2023
Closed
@chalmerlowe
Copy link
Collaborator

Nishant did some experimentation and determined that there was a dependency on pytz via pyarrow.

Closing this PR for now.

Running into

pyarrow.lib.ArrowInvalid: Pytz package or Python>=3.8 for zoneinfo module must be installed
but this error message from pyarrow seems incorrect, since zoneinfo is introduced in Python 3.9.

Solutions would be to upgrade bigquery-sql-alchemy to Python 3.9 now or wait a year (when Python 3.8 is depreciated) to remove the pytz dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
3 participants
@tswast @meredithslota @chalmerlowe