Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid creating aliases for already-known tables #361

Merged
merged 1 commit into from Oct 26, 2021
Merged

fix: avoid creating aliases for already-known tables #361

merged 1 commit into from Oct 26, 2021

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 26, 2021

Closes #353.

@tseaver tseaver requested a review from tswast October 26, 2021 18:41
@tseaver tseaver requested a review from a team as a code owner October 26, 2021 18:41
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 26, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label Oct 26, 2021
tswast
tswast approved these changes Oct 26, 2021
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tswast tswast merged commit 1ce4e14 into main Oct 26, 2021
@tswast tswast deleted the 353-no-alias-for-known-table branch October 26, 2021 20:48
@tswast tswast mentioned this pull request Oct 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unnest function in BigQuery SQLAlchemy plugin joins twice when selecting other columns
2 participants
@tseaver @tswast