Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: supports_multivalues_insert dialect option was mispelled #278

Merged
merged 5 commits into from Aug 19, 2021
Merged

fix: supports_multivalues_insert dialect option was mispelled #278

merged 5 commits into from Aug 19, 2021

Conversation

jimfulton
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #226 🦕

Supersedes #224

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label Aug 18, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 18, 2021
@jimfulton
Copy link
Contributor Author

Interesting.

  1. I was able to write a little test for your use case.
  2. There aren't any dialect-compliance tests for this feature. :(

@jimfulton jimfulton marked this pull request as ready for review August 19, 2021 20:09
@jimfulton jimfulton requested a review from a team as a code owner August 19, 2021 20:09
@jimfulton jimfulton merged commit ec36a12 into googleapis:master Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

supports_multivalues_insert dialect setting is mispelled.
2 participants
@jimfulton @tseaver