feat: Alembic support #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fixtures that we were autousing needed to be used explicitly, to get randomly-generated dataset names. One was only used for one test. Also, fixed copyright.
We don't require alembic and most tests should run without it, however - We run some unit tests (Python 3.8) to cover the alembic registration that happens when alembic is installed. - We have a system test that demonstrates working with alembic and proves that the things we think should work do work. :)
product-auto-label
bot
added
the
api: bigquery
google-cla
bot
added
the
cla: yes
shollyman
approved these changes
May 25, 2021
| """ | ||
| ) | ||
|
|
||
| # The only thing we can alter about a column is we can make it |
There was a problem hiding this comment.
This will change, but we're not currently watching the changes for the DDL params closely. Will need to figure out how to notify on changes like this. https://cloud.google.com/bigquery/docs/release-notes is how the team signals these changes for syntax historically.
There was a problem hiding this comment.
Hah! They just added table rename the other day.
tseaver
approved these changes
May 25, 2021
| except ImportError: | ||
| pass | ||
| else: | ||
| from alembic.ddl import impl |
There was a problem hiding this comment.
FWIW you could appease flake8 by just importing impl above, rather than the bare import alembic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #65 馃