Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support parameterized NUMERIC, BIGNUMERIC, STRING, and BYTES types #180

Merged
merged 8 commits into from May 24, 2021
Merged

feat: Support parameterized NUMERIC, BIGNUMERIC, STRING, and BYTES types #180

merged 8 commits into from May 24, 2021

Conversation

jimfulton
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #178 🦕

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label May 21, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 21, 2021
@jimfulton jimfulton marked this pull request as ready for review May 22, 2021 23:05
@jimfulton jimfulton requested a review from a team as a code owner May 22, 2021 23:05
tseaver
tseaver reviewed May 24, 2021
View reviewed changes
pybigquery/_helpers.py Outdated Show resolved Hide resolved
pybigquery/sqlalchemy_bigquery.py Show resolved Hide resolved
@jimfulton
Copy link
Contributor Author

@tseaver Thanks for looking at this!

@jimfulton
Simplified substitute_re_method
2ee6935 
By splitting string replacement into separate function, substitute_string_re_method.
@jimfulton
Converted non-trivial regular expressions to verbose format.
3a69740
@jimfulton jimfulton merged commit d118238 into master May 24, 2021
@jimfulton jimfulton deleted the riversnake-parameterized-types branch May 24, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQuery - Parameterized Types
2 participants
@jimfulton @tseaver