Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use project_id property from service account credentials #120

Merged
merged 3 commits into from Apr 12, 2021
Merged

fix: use project_id property from service account credentials #120

merged 3 commits into from Apr 12, 2021

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Apr 12, 2021 •
edited

Adds system tests for greater assurance that these code paths function as expected.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #118 馃

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label Apr 12, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 12, 2021
@tswast tswast mentioned this pull request Apr 12, 2021
Closed
@tswast tswast merged commit ab2051d into googleapis:master Apr 12, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 12, 2021
@release-please
chore: release 0.6.1 (#121)
75a6458 
馃 I have created a release \*beep\* \*boop\*
---
### [0.6.1](https://www.github.com/googleapis/python-bigquery-sqlalchemy/compare/v0.6.0...v0.6.1) (2021-04-12)


### Bug Fixes

* use `project_id` property from service account credentials ([#120](https://www.github.com/googleapis/python-bigquery-sqlalchemy/issues/120)) ([ab2051d](https://www.github.com/googleapis/python-bigquery-sqlalchemy/commit/ab2051de3097adb68503c01a87f9a91092711d2a))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
jimfulton
jimfulton reviewed Apr 13, 2021
View reviewed changes
Copy link
Contributor

@jimfulton jimfulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a system rather than a unit test?

tests/system/test_helpers.py
@pytest.fixture(scope="session")
def module_under_test():
from pybigquery import _helpers

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's he purpose of this?

Why not just refer to _helpers? Do we think the name is likely to change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimfulton jimfulton jimfulton left review comments

@shollyman shollyman shollyman approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

explicit credentials authentication broken
3 participants
@tswast @jimfulton @shollyman