Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fetch table and column descriptions during reflection #115

Merged
merged 1 commit into from Apr 6, 2021
Merged

feat: fetch table and column descriptions during reflection #115

merged 1 commit into from Apr 6, 2021

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Apr 6, 2021

This empty commit is a follow-up to PR #82,
It should allow release-please to update the changelog.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@tswast
feat: fetch table and column descriptions during reflection
a3fe9ac 
This empty commit is a follow-up to PR googleapis#82,
It should allow release-please to update the changelog.
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label Apr 6, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 6, 2021
plamut
plamut approved these changes Apr 6, 2021
View reviewed changes
Copy link

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Have never seen such Zen PR before. 💯

@tswast tswast merged commit 7b14a06 into googleapis:master Apr 6, 2021
@tswast tswast deleted the pr82-fetch_descriptions branch April 6, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut approved these changes

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tswast @plamut @busunkim96