From 2cf05a0f37e32344b29ba2e92d709f7e51b20916 Mon Sep 17 00:00:00 2001 From: Jim Fulton Date: Mon, 23 Aug 2021 11:27:28 -0400 Subject: [PATCH] fix: dialect atribute wasn't provided (#291) --- sqlalchemy_bigquery/__init__.py | 2 +- sqlalchemy_bigquery/base.py | 2 ++ tests/unit/test_sqlalchemy_bigquery.py | 7 +++++++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/sqlalchemy_bigquery/__init__.py b/sqlalchemy_bigquery/__init__.py index e3dd3f2d..a9321ed5 100644 --- a/sqlalchemy_bigquery/__init__.py +++ b/sqlalchemy_bigquery/__init__.py @@ -22,7 +22,7 @@ from .version import __version__ # noqa -from .base import BigQueryDialect +from .base import BigQueryDialect, dialect # noqa from .base import ( STRING, BOOL, diff --git a/sqlalchemy_bigquery/base.py b/sqlalchemy_bigquery/base.py index a51e4748..a9539f5d 100644 --- a/sqlalchemy_bigquery/base.py +++ b/sqlalchemy_bigquery/base.py @@ -986,6 +986,8 @@ def get_view_definition(self, connection, view_name, schema=None, **kw): return view.view_query +dialect = BigQueryDialect + try: import alembic # noqa except ImportError: diff --git a/tests/unit/test_sqlalchemy_bigquery.py b/tests/unit/test_sqlalchemy_bigquery.py index 0d18a048..a4c81367 100644 --- a/tests/unit/test_sqlalchemy_bigquery.py +++ b/tests/unit/test_sqlalchemy_bigquery.py @@ -171,3 +171,10 @@ def test_multi_value_insert(faux_conn, last_query): " (%(id_m0:INT64)s), (%(id_m1:INT64)s), (%(id_m2:INT64)s)", {"id_m0": 0, "id_m1": 1, "id_m2": 2}, ) + + +def test_follow_dialect_attribute_convention(): + import sqlalchemy_bigquery.base + + assert sqlalchemy_bigquery.dialect is sqlalchemy_bigquery.BigQueryDialect + assert sqlalchemy_bigquery.base.dialect is sqlalchemy_bigquery.BigQueryDialect