Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

docs: remove redundant samples #86

Merged
merged 1 commit into from Dec 21, 2020

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Dec 15, 2020

Snippets updated in internal CL 347667754

Removes redundant samples now that there are copies in the snippets directory from #83

@tswast tswast requested a review from a team as a code owner December 15, 2020 22:25
@tswast tswast requested review from tmatsuo and removed request for a team December 15, 2020 22:25
@snippet-bot
Copy link

snippet-bot bot commented Dec 15, 2020

Here is the summary of changes.

You deleted 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 15, 2020
@product-auto-label product-auto-label bot added api: bigquerydatatransfer Issues related to the googleapis/python-bigquery-datatransfer API. samples Issues that are directly related to samples. labels Dec 15, 2020
@tswast tswast added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 15, 2020
@tmatsuo
Copy link
Contributor

tmatsuo commented Dec 15, 2020

@tswast

The bot currently warns when you delete a region tag which is used by Sample Browser. You can safely ignore the warning because Sample Browser should be able to self heal with the new region tag location.

FYI, we're planning to distinguish the sample browser pages in the future.

Copy link
Contributor

@tmatsuo tmatsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the internal CL landed (it may take a while for propagating), please use the "Refresh this comment" checkbox in the snippet-bot's comment.

@tswast tswast removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 21, 2020
@tswast tswast merged commit 093e407 into googleapis:master Dec 21, 2020
@tswast tswast deleted the b143380740-cleanup-samples branch December 21, 2020 14:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: bigquerydatatransfer Issues related to the googleapis/python-bigquery-datatransfer API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants