This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
fix!: avoid collision with built-in functions by renaming type property to type_ #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshi-automation
requested review from
tmatsuo
and removed request for
a team
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigquerydatatransfer
autosynth cannot find the source of changes triggered by earlier changes in this
repository, or by version upgrades to tools such as linters.
https://github.com/googleapis/python-talent/blob/ef045e8eb348db36d7a2a611e6f26b11530d273b/samples/snippets/noxfile_config.py#L27-L32 `BUILD_SPECIFIC_GCLOUD_PROJECT` is an alternate project used for sample tests that do poorly with concurrent runs on the same project. Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Source-Date: Wed Sep 30 13:06:03 2020 -0600 Source-Repo: googleapis/synthtool Source-Sha: 9b0da5204ab90bcc36f8cd4e5689eff1a54cc3e4 Source-Link: googleapis/synthtool@9b0da52
yoshi-automation
force-pushed
the
autosynth-synthtool
branch
from
efb617f
to
f31041a
Compare
tmatsuo
changed the title
tmatsuo
approved these changes
Oct 8, 2020
tswast
reviewed
Oct 12, 2020
| @@ -70,7 +70,7 @@ class DataSourceParameter(proto.Message): | |||
| Parameter display name in the user interface. | |||
| description (str): | |||
| Parameter description. | |||
| type (~.datatransfer.DataSourceParameter.Type): | |||
| type_ (~.datatransfer.DataSourceParameter.Type): | |||
There was a problem hiding this comment.
This is a breaking change. Can we merge separately?
tswast
changed the title
tswast
approved these changes
Oct 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
typeis renamed totype_to avoid conflict with built-in functions (introduced in googleapis/gapic-generator-python#595)This PR was generated using Autosynth. 馃寛
Synth log will be available here:
https://source.cloud.google.com/results/invocations/ee4b6a36-4a41-4223-b32a-41efe623cae3/targets
Source-Link: googleapis/synthtool@9b0da52