Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

Update sample code to also test REST transport #440

Closed
parthea opened this issue Feb 16, 2023 · 2 comments
Closed

Update sample code to also test REST transport #440

parthea opened this issue Feb 16, 2023 · 2 comments
Labels
api: bigquerydatatransfer Issues related to the googleapis/python-bigquery-datatransfer API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples.

Comments

@parthea
Copy link
Contributor

parthea commented Feb 16, 2023

PR #439 added support for using REST transport. We should also update the handwritten sample code here to support both gRPC and REST transport.

@parthea parthea added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. samples Issues that are directly related to samples. labels Feb 16, 2023
@product-auto-label product-auto-label bot added the api: bigquerydatatransfer Issues related to the googleapis/python-bigquery-datatransfer API. label Feb 16, 2023
@tswast
Copy link
Contributor

tswast commented Feb 16, 2023

Some words of caution:

BQ-DTS defaults to a very limited quota of like 4 API calls per minute or something tiny like that. Adding REST samples may double the quota used.

Even when we updated the samples tests to use a per-Python version project in googleapis/synthtool#778, it was somehow still using up the Kokoro build pool project's quota until I hacked the quota project config in the "transfer_client" fixture in https://github.com/googleapis/python-bigquery-datatransfer/pull/83/files

At least at the time of #83, there was very limited quota and not much capacity available when we asked for more. It has been three years, so we might be able to revisit that request for more quota.

@parthea parthea added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Mar 3, 2023
@parthea
Copy link
Contributor Author

parthea commented Apr 18, 2023

Closing based on the comment that there is limited quota for testing #440 (comment)

@parthea parthea closed this as completed Apr 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: bigquerydatatransfer Issues related to the googleapis/python-bigquery-datatransfer API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples.
Projects
None yet
Development

No branches or pull requests

2 participants