Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

AutoML: update_column_spec typo in TablesClient docstring #17

Closed
na0fu3y opened this issue Mar 9, 2020 · 0 comments · Fixed by #18
Closed

AutoML: update_column_spec typo in TablesClient docstring #17

na0fu3y opened this issue Mar 9, 2020 · 0 comments · Fixed by #18
Assignees
@helinwang
Labels
api: automl Issues related to the googleapis/python-automl API. priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. type: docs Improvement to the documentation for an API.

Comments

@na0fu3y
Copy link
Contributor

na0fu3y commented Mar 9, 2020

The TablesClient docstring contains the non-existent function update_column_specs, and fixed it to update_column_spec which I think is more appropriate.

Code

https://github.com/googleapis/python-automl/blob/master/google/cloud/automl_v1beta1/tables/tables_client.py#L1188

client.update_column_specs(dataset_display_name='my_dataset',
    column_spec_display_name='Outcome', type_code='CATEGORY')

The code cause exception like

AttributeError: 'TablesClient' object has no attribute 'update_column_specs'
@na0fu3y na0fu3y mentioned this issue Mar 9, 2020
Merged
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Mar 9, 2020
@JustinBeckwith JustinBeckwith mentioned this issue Mar 16, 2020
Closed
@busunkim96 busunkim96 added api: automl Issues related to the googleapis/python-automl API. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Mar 16, 2020
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Mar 16, 2020
@busunkim96 busunkim96 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed triage me I really want to be triaged. 🚨 This issue needs some love. labels Mar 16, 2020
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. and removed triage me I really want to be triaged. 🚨 This issue needs some love. labels Mar 16, 2020
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Jun 14, 2020
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Sep 5, 2020
@munkhuushmgl munkhuushmgl added type: docs Improvement to the documentation for an API. and removed 🚨 This issue needs some love. labels Sep 8, 2020
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Sep 8, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Sep 9, 2020
@na0fu3y
fix: update_column_spec typo in TablesClient docstring (#18)
9feb4cc 
The docstring contains the non-existent function `update_column_specs`, and fixed it to` update_column_spec` which I think is more appropriate.

The code cause AttributeError: 'TablesClient' object has no attribute 'update_column_specs'.

Fixes #17 🦕
gcf-merge-on-green bot pushed a commit that referenced this issue Sep 16, 2020
@release-please
chore: release 2.0.0 (#68)
4c5d862 
🤖 I have created a release \*beep\* \*boop\* 
---
## [2.0.0](https://www.github.com/googleapis/python-automl/compare/v1.0.1...v2.0.0) (2020-09-16)


### ⚠ BREAKING CHANGES

* move to microgen (#61)

### Features

* move to microgen ([#61](https://www.github.com/googleapis/python-automl/issues/61)) ([009085e](https://www.github.com/googleapis/python-automl/commit/009085e0a82d1d7729349746c2c8954d5d60e0a9))


### Bug Fixes

* **translate:** fix a broken test [([#4360](https://www.github.com/googleapis/python-automl/issues/4360))](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/4360) ([5f7d141](https://www.github.com/googleapis/python-automl/commit/5f7d141afe732acf7458a9ac98618e93baa93d38)), closes [#4353](https://www.github.com/googleapis/python-automl/issues/4353)
* `update_column_spec` typo in TablesClient docstring ([#18](https://www.github.com/googleapis/python-automl/issues/18)) ([9feb4cc](https://www.github.com/googleapis/python-automl/commit/9feb4cc5e04a01a4199da43400457cca6c0bfa05)), closes [#17](https://www.github.com/googleapis/python-automl/issues/17)
* update retry configs ([#44](https://www.github.com/googleapis/python-automl/issues/44)) ([7df9059](https://www.github.com/googleapis/python-automl/commit/7df905910b86721a6ee3a3b6c916a4f8e27d0aa7))


### Documentation

* add cancel operation sample ([abc5070](https://www.github.com/googleapis/python-automl/commit/abc507005d5255ed5adf2c4b8e0b23042a0bdf47))
* add samples from tables/automl ([#54](https://www.github.com/googleapis/python-automl/issues/54)) ([d225a5f](https://www.github.com/googleapis/python-automl/commit/d225a5f97c2823218b91a79e77d3383132875231)), closes [#2090](https://www.github.com/googleapis/python-automl/issues/2090) [#2100](https://www.github.com/googleapis/python-automl/issues/2100) [#2102](https://www.github.com/googleapis/python-automl/issues/2102) [#2103](https://www.github.com/googleapis/python-automl/issues/2103) [#2101](https://www.github.com/googleapis/python-automl/issues/2101) [#2110](https://www.github.com/googleapis/python-automl/issues/2110) [#2115](https://www.github.com/googleapis/python-automl/issues/2115) [#2150](https://www.github.com/googleapis/python-automl/issues/2150) [#2145](https://www.github.com/googleapis/python-automl/issues/2145) [#2203](https://www.github.com/googleapis/python-automl/issues/2203) [#2340](https://www.github.com/googleapis/python-automl/issues/2340) [#2337](https://www.github.com/googleapis/python-automl/issues/2337) [#2336](https://www.github.com/googleapis/python-automl/issues/2336) [#2339](https://www.github.com/googleapis/python-automl/issues/2339) [#2338](https://www.github.com/googleapis/python-automl/issues/2338) [#2276](https://www.github.com/googleapis/python-automl/issues/2276) [#2257](https://www.github.com/googleapis/python-automl/issues/2257) [#2424](https://www.github.com/googleapis/python-automl/issues/2424) [#2407](https://www.github.com/googleapis/python-automl/issues/2407) [#2501](https://www.github.com/googleapis/python-automl/issues/2501) [#2459](https://www.github.com/googleapis/python-automl/issues/2459) [#2601](https://www.github.com/googleapis/python-automl/issues/2601) [#2523](https://www.github.com/googleapis/python-automl/issues/2523) [#2005](https://www.github.com/googleapis/python-automl/issues/2005) [#3033](https://www.github.com/googleapis/python-automl/issues/3033) [#2806](https://www.github.com/googleapis/python-automl/issues/2806) [#3750](https://www.github.com/googleapis/python-automl/issues/3750) [#3571](https://www.github.com/googleapis/python-automl/issues/3571) [#3929](https://www.github.com/googleapis/python-automl/issues/3929) [#4022](https://www.github.com/googleapis/python-automl/issues/4022) [#4127](https://www.github.com/googleapis/python-automl/issues/4127)
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@helinwang helinwang

Labels
api: automl Issues related to the googleapis/python-automl API. priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update_column_spec typo in TablesClient docstring na0fu3y/python-automl
5 participants
@helinwang @busunkim96 @na0fu3y @yoshi-automation @munkhuushmgl