This repository has been archived by the owner on Dec 31, 2023. It is now read-only.
docs: re-publish tables client documentation #146
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: automl
Issues related to the googleapis/python-automl API.
label
Apr 14, 2021
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Apr 14, 2021
busunkim96
commented
Apr 14, 2021
@@ -58,12 +58,11 @@ | |||
|
|||
s.replace( | |||
"docs/automl_v1beta1/services.rst", | |||
"""(google\.cloud\.automl_v1beta1\.services\.prediction_service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjusted to match the new format of services.rst
.
@@ -79,9 +78,6 @@ | |||
|
|||
s.move(templated_files) | |||
|
|||
# TODO(busunkim): Use latest sphinx after microgenerator transition | |||
s.replace("noxfile.py", """['"]sphinx['"]""", '"sphinx<3.0.0"') | |||
# TODO(busunkim): Remove after microgenerator transition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleanup
@@ -90,12 +86,4 @@ | |||
\s+'-T', \# show full traceback on exception""", | |||
""""-T", # show full traceback on exception""") | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like above, cleanup of replacement that is no longer needed
helinwang
approved these changes
Apr 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!!
busunkim96
added
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Apr 14, 2021
gcf-merge-on-green
bot
removed
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Apr 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
api: automl
Issues related to the googleapis/python-automl API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tables client documentation got deleted on accident - this re-adds the
TablesClient
andGcsClient
underautoml_v1beta1
. Verify locally by runningnox -s docs
and looking at the output indocs/_build/html
.Fixes b/184554120