Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

Commit

Permalink
Browse files Browse the repository at this point in the history
fix(automl): fix TypeError when passing a client_info to automl Table…
…sClient (#9949)

* fix(automl): fix TypeError when passing a client_info to automl TablesClient

The solution is to delete client_info from kwargs instead and pass named parameter.
  • Loading branch information
vimota authored and helinwang committed Dec 17, 2019
1 parent f080ad9 commit 75783ec
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
1 change: 1 addition & 0 deletions google/cloud/automl_v1beta1/tables/tables_client.py
Expand Up @@ -104,6 +104,7 @@ def __init__(
else:
client_info_.user_agent = user_agent
client_info_.gapic_version = version
kwargs.pop("client_info", None)

if client is None:
self.auto_ml_client = gapic.auto_ml_client.AutoMlClient(
Expand Down
11 changes: 11 additions & 0 deletions tests/unit/gapic/v1beta1/test_tables_client_v1beta1.py
Expand Up @@ -1424,3 +1424,14 @@ def test_prediction_client_credentials(self):
_, prediction_client_kwargs = MockPredictionClient.call_args
assert "credentials" in prediction_client_kwargs
assert prediction_client_kwargs["credentials"] == credentials_mock

def test_prediction_client_client_info(self):
client_info_mock = mock.Mock()
patch_prediction_client = mock.patch(
"google.cloud.automl_v1beta1.gapic.prediction_service_client.PredictionServiceClient"
)
with patch_prediction_client as MockPredictionClient:
client = automl_v1beta1.TablesClient(client_info=client_info_mock)
_, prediction_client_kwargs = MockPredictionClient.call_args
assert "client_info" in prediction_client_kwargs
assert prediction_client_kwargs["client_info"] == client_info_mock

0 comments on commit 75783ec

Please sign in to comment.