Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use version.py instead of pkg_resources.get_distribution #80

Merged
merged 5 commits into from Oct 5, 2020
Merged

fix: use version.py instead of pkg_resources.get_distribution #80

merged 5 commits into from Oct 5, 2020

Conversation

crwilcox
Copy link
Contributor

@crwilcox crwilcox commented Oct 2, 2020 •
edited

Related: #27

@crwilcox crwilcox requested a review from a team as a code owner October 2, 2020 22:05
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 2, 2020
andrewsg
andrewsg approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chris! Do we need to change release-please or any other tooling?

google/api_core/version.py Outdated Show resolved Hide resolved
@crwilcox
Copy link
Contributor Author

crwilcox commented Oct 5, 2020

@andrewsg already underway and part of next release-please release.

@crwilcox crwilcox merged commit d480d97 into master Oct 5, 2020
@tseaver tseaver mentioned this pull request Oct 6, 2020
Closed
@tswast tswast mentioned this pull request Oct 6, 2020
Closed
@busunkim96 busunkim96 mentioned this pull request Oct 14, 2020
Open
@tseaver tseaver deleted the use-version-py branch December 8, 2020 18:13
@busunkim96 busunkim96 mentioned this pull request Feb 4, 2021
Merged
gcf-merge-on-green bot pushed a commit to googleapis/google-auth-library-python that referenced this pull request Mar 16, 2021
@busunkim96
feat: expose library version at google.auth.__version (#683)
a2cbc32 
Move the version from `setup.py` to `google/auth/version.py`.  Same as googleapis/python-api-core#80.  (see googleapis/python-api-core#27 for motivation). This is option 3 in https://packaging.python.org/guides/single-sourcing-package-version/.

This unblocks a version check I'd like to add in googleapis/python-api-core#134.

Usage:

```py
>>> import google.auth
>>> google.auth.__version__
'1.25.0'
```
@Nour-Mws Nour-Mws mentioned this pull request Feb 10, 2023
Merged
@bricker bricker mentioned this pull request May 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsg andrewsg andrewsg approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@crwilcox @andrewsg