Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consolidate duplicated code #593

Open
1 task
vchudnov-g opened this issue Feb 1, 2024 · 0 comments
Open
1 task

consolidate duplicated code #593

vchudnov-g opened this issue Feb 1, 2024 · 0 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@vchudnov-g
Copy link
Contributor

vchudnov-g commented Feb 1, 2024 •
edited

We should reduce duplicated code and consolidate sensibly, in a way that makes it clear to developers what the code flow is. Some instances to look at (add more as you find them):

  • google/api_core/grpc_helpers{,_async}.py (and their tests) seem to have duplicate or very similar code
@vchudnov-g vchudnov-g added type: cleanup An internal cleanup or hygiene concern. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Feb 1, 2024
@vchudnov-g vchudnov-g mentioned this issue Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vchudnov-g