Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using ssl_credentials and attempt_direct_path in google.api_core.grpc_helpers.create_channel #590

Open
parthea opened this issue Jan 31, 2024 · 0 comments
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@parthea
Copy link
Collaborator

parthea commented Jan 31, 2024

Related to PR #583, it is not supported to use attempt_direct_path and ssl_credentials because we use grpc.compute_engine_channel_credentials for Direct Path which doesn't support passing ssl_credentials. Support for mTLS and Direct Path will be added later.

See the comment below

    # if `ssl_credentials` is set, use `grpc.composite_channel_credentials` instead of
    # `grpc.compute_engine_channel_credentials` as the former supports passing
    # `ssl_credentials` via `channel_credentials` which is needed for mTLS.
@parthea parthea added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

1 participant