Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for maxAttempts in retries #535

Open
ohmayr opened this issue Oct 5, 2023 · 0 comments
Open

Support for maxAttempts in retries #535

ohmayr opened this issue Oct 5, 2023 · 0 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release.

Comments

@ohmayr
Copy link
Contributor

ohmayr commented Oct 5, 2023

Both google.api_core.retry.Retry and google.api_core.retry_async.AsyncRetry terminate once the timeout value is reached.

It seems like we need to support maxAttempts in retries for users so that the retry policy adheres to the following AIP:
https://google.aip.dev/client-libraries/4221#client-library-generator-retry-configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ohmayr